Code Reviews "When a group of people fuse into a meaningful whole, the entire character of the work changes." Peopleware "A jelled team is a group of people so strongly knit that the whole is greater than the sum of the parts." TRUST 🔨 🔧 🪛 Building Trust 👩💻 💡 Ideas Work ❤ Compassion Insensitive Feedback No. This can't possibly work. I don't agree with these changes. This is unacceptable. You might as well do this over. Considerate Feedback Nice work and thanks for folding in the feedback. Have you thought about the security implications? What about using the following solution? Would you want to use the following instead? Maybe leverage this aspect of the architecture instead? Feedback Categories Blocking Non-blocking • Requires immediate attention. • Must be fixed. • Informative or suggestive. • Author's discretion. • Changes are encouraged. • Discussion can continue. Feedback Format <emoticon> <message>. 🎨 Would you want to use `Object#then` to avoid the temporary local variable? Emoticons ℹ 💭 💡 ⚠ 🎨 🛑 🙇 ❇ 📛 🪓 🍄 Emoticons ℹ 💭 💡 ⚠ 🎨 🛑 🙇 ❇ 📛 🪓 🍄 Encouraging/Informational Concerning/Actionable Emoticons ℹ 💭 💡 ⚠ 🎨 🛑 🙇 ❇ 📛 🪓 🍄 Blues / Whites Emoticons ℹ 💭 💡 ⚠ 🎨 🛑 🙇 ❇ 📛 🪓 🍄 Yellows Emoticons ℹ 💭 💡 ⚠ 🎨 🛑 🙇 ❇ 📛 🪓 🍄 Reds Emoticons ℹ 💭 💡 ⚠ 🎨 🛑 🙇 ❇ 📛 🪓 🍄 Greens (mixed) Information ℹ • Non-blocking. • Status update. • Generally doesn't need a response. :information_source: Information (examples) ℹ Will rebase onto `main` once build is green. ℹ Rebasing to resolve upstream merge conflicts. ℹ All feedback has been addressed and ready for re-review. ℹ Inquire 💭 • Non-blocking. • A chance to learn more. :thought_balloon: 💭 We should consider leveraging the Command Pattern for these objects soon. 💭 Since this pattern exhibits The Rule of Three , should we plan to DRY this up soon? Inquire (examples) 💭 Tip 💡 • Non-blocking or blocking. • A chance to educate. :bulb: 💡 You might want to study the use of whole value objects when it comes to immutability. 💡 You might enjoy looking at existing examples of pattern matching Tip (examples) 💡